]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: remove unneeded assignment in __iio_format_value
authorMatteo Martelli <matteomartelli3@gmail.com>
Tue, 30 Jul 2024 09:43:49 +0000 (11:43 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 10 Aug 2024 10:17:33 +0000 (11:17 +0100)
Trivial cleanup in __iio_format_value() for the IIO_VAL_FRACTIONAL case
where tmp1 = vals[1] assignment is unneeded and irrelevant since tmp1 is
immediately overwritten by the subsequent div_s64_rem() call.

Signed-off-by: Matteo Martelli <matteomartelli3@gmail.com>
Link: https://patch.msgid.link/20240730-iio-clean-fmt-value-v1-1-3e1c3deafc33@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/industrialio-core.c

index f18f48c7eb037299f625a1061557aa1765ebc4d9..3f2bc6451325e366cd9c988eec74ee523d5e0840 100644 (file)
@@ -667,7 +667,6 @@ static ssize_t __iio_format_value(char *buf, size_t offset, unsigned int type,
                                             vals[1]);
        case IIO_VAL_FRACTIONAL:
                tmp2 = div_s64((s64)vals[0] * 1000000000LL, vals[1]);
-               tmp1 = vals[1];
                tmp0 = (int)div_s64_rem(tmp2, 1000000000, &tmp1);
                if ((tmp2 < 0) && (tmp0 == 0))
                        return sysfs_emit_at(buf, offset, "-0.%09u", abs(tmp1));