]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-smtp: smtp-server-cmd-vrfy - Restructure parameter parsing.
authorStephan Bosch <stephan.bosch@open-xchange.com>
Tue, 24 Mar 2020 20:05:17 +0000 (21:05 +0100)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Wed, 20 May 2020 05:26:26 +0000 (05:26 +0000)
src/lib-smtp/smtp-server-cmd-vrfy.c

index dc5777ac3e640af2c0c6a582dfef1a16704dc2a3..6eb2ae82dd9e41b658974d175416e6918aeb866f 100644 (file)
@@ -18,15 +18,12 @@ void smtp_server_cmd_vrfy(struct smtp_server_cmd_ctx *cmd,
 
        /* vrfy = "VRFY" SP String CRLF */
        ret = smtp_string_parse(params, &param, &error);
-       if (ret <= 0) {
-               if (ret < 0) {
-                       smtp_server_reply(cmd, 501, "5.5.4",
-                                         "Invalid string parameter: %s",
-                                         error);
-               } else {
-                       smtp_server_reply(cmd, 501, "5.5.4",
-                                         "Invalid parameters");
-               }
+       if (ret < 0) {
+               smtp_server_reply(cmd, 501, "5.5.4",
+                                 "Invalid string parameter: %s", error);
+               return;
+       } else if (ret == 0) {
+               smtp_server_reply(cmd, 501, "5.5.4", "Invalid parameters");
                return;
        }