]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
arm64: tegra: Fix 'active-low' warning for Jetson TX1 regulator
authorJon Hunter <jonathanh@nvidia.com>
Wed, 25 Sep 2019 14:12:29 +0000 (15:12 +0100)
committerThierry Reding <treding@nvidia.com>
Tue, 29 Oct 2019 19:30:04 +0000 (20:30 +0100)
Commit 34993594181d ("arm64: tegra: Enable HDMI on Jetson TX1")
added a regulator for HDMI on the Jetson TX1 platform. This regulator
has an active high enable, but the GPIO specifier for enabling the
regulator incorrectly defines it as active-low. This causes the
following warning to occur on boot ...

 WARNING KERN regulator@10 GPIO handle specifies active low - ignored

The fixed-regulator binding does not use the active-low flag from the
gpio specifier and purely relies of the presence of the
'enable-active-high' property to determine if it is active high or low
(if this property is omitted). Fix this warning by setting the GPIO
to active-high in the GPIO specifier which aligns with the presense of
the 'enable-active-high' property.

Fixes: 34993594181d ("arm64: tegra: Enable HDMI on Jetson TX1")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi

index a7dc319214a4db1bb98d614ac0fa822186846472..b0095072bc28e6b05ea704f6ebe31913ad4541c8 100644 (file)
                        regulator-name = "VDD_HDMI_5V0";
                        regulator-min-microvolt = <5000000>;
                        regulator-max-microvolt = <5000000>;
-                       gpio = <&exp1 12 GPIO_ACTIVE_LOW>;
+                       gpio = <&exp1 12 GPIO_ACTIVE_HIGH>;
                        enable-active-high;
                        vin-supply = <&vdd_5v0_sys>;
                };