]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
6.12-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Jan 2025 14:40:51 +0000 (15:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Jan 2025 14:40:51 +0000 (15:40 +0100)
added patches:
io_uring-rsrc-require-cloned-buffers-to-share-accounting-contexts.patch

queue-6.12/io_uring-rsrc-require-cloned-buffers-to-share-accounting-contexts.patch [new file with mode: 0644]
queue-6.12/series

diff --git a/queue-6.12/io_uring-rsrc-require-cloned-buffers-to-share-accounting-contexts.patch b/queue-6.12/io_uring-rsrc-require-cloned-buffers-to-share-accounting-contexts.patch
new file mode 100644 (file)
index 0000000..8e0b4df
--- /dev/null
@@ -0,0 +1,44 @@
+From 605dc321522f4334849759d9585bef54dc60994f Mon Sep 17 00:00:00 2001
+From: Jann Horn <jannh@google.com>
+Date: Tue, 14 Jan 2025 18:49:00 +0100
+Subject: io_uring/rsrc: require cloned buffers to share accounting contexts
+
+From: Jann Horn <jannh@google.com>
+
+Commit 19d340a2988d4f3e673cded9dde405d727d7e248 upstream.
+
+When IORING_REGISTER_CLONE_BUFFERS is used to clone buffers from uring
+instance A to uring instance B, where A and B use different MMs for
+accounting, the accounting can go wrong:
+If uring instance A is closed before uring instance B, the pinned memory
+counters for uring instance B will be decremented, even though the pinned
+memory was originally accounted through uring instance A; so the MM of
+uring instance B can end up with negative locked memory.
+
+Cc: stable@vger.kernel.org
+Closes: https://lore.kernel.org/r/CAG48ez1zez4bdhmeGLEFxtbFADY4Czn3CV0u9d_TMcbvRA01bg@mail.gmail.com
+Fixes: 7cc2a6eadcd7 ("io_uring: add IORING_REGISTER_COPY_BUFFERS method")
+Signed-off-by: Jann Horn <jannh@google.com>
+Link: https://lore.kernel.org/r/20250114-uring-check-accounting-v1-1-42e4145aa743@google.com
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ io_uring/rsrc.c |    7 +++++++
+ 1 file changed, 7 insertions(+)
+
+--- a/io_uring/rsrc.c
++++ b/io_uring/rsrc.c
+@@ -1154,6 +1154,13 @@ static int io_clone_buffers(struct io_ri
+       int i, ret, nbufs;
+       /*
++       * Accounting state is shared between the two rings; that only works if
++       * both rings are accounted towards the same counters.
++       */
++      if (ctx->user != src_ctx->user || ctx->mm_account != src_ctx->mm_account)
++              return -EINVAL;
++
++      /*
+        * Drop our own lock here. We'll setup the data we need and reference
+        * the source buffers, then re-grab, check, and assign at the end.
+        */
index bd115053a6b575b991d726c8b788109b293d2f3c..2f9df21586a8e3b8efc25485af7d8ae214f6aa40 100644 (file)
@@ -38,3 +38,4 @@ input-xpad-add-qh-electronics-vid-pid.patch
 input-xpad-improve-name-of-8bitdo-controller-2dc8-3106.patch
 input-xpad-add-support-for-nacon-evol-x-xbox-one-controller.patch
 input-xpad-add-support-for-wooting-two-he-arm.patch
+io_uring-rsrc-require-cloned-buffers-to-share-accounting-contexts.patch