]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
Make "headers too large" test understand 431 response code.
authorBen Darnell <ben@bendarnell.com>
Sun, 25 Oct 2015 17:52:25 +0000 (13:52 -0400)
committerBen Darnell <ben@bendarnell.com>
Sun, 25 Oct 2015 17:52:25 +0000 (13:52 -0400)
tornado/test/httpserver_test.py

index 859d817d0d92269edc89dcb8e05314417ba31ef3..065f5b1fade3c3fe27caecbc7263228476cb1f2f 100644 (file)
@@ -899,9 +899,12 @@ class MaxHeaderSizeTest(AsyncHTTPTestCase):
         self.assertEqual(response.body, b"Hello world")
 
     def test_large_headers(self):
-        with ExpectLog(gen_log, "Unsatisfiable read"):
+        with ExpectLog(gen_log, "Unsatisfiable read", required=False):
             response = self.fetch("/", headers={'X-Filler': 'a' * 1000})
-        self.assertEqual(response.code, 599)
+        # 431 is "Request Header Fields Too Large", defined in RFC
+        # 6585. However, many implementations just close the
+        # connection in this case, resulting in a 599.
+        self.assertIn(response.code, (431, 599))
 
 
 @skipOnTravis