BUG/MAJOR: threads/lb: fix missing unlock on consistent hash LB

If no matching node was found, the function was left without unlocking
the tree.

diff --git a/src/lb_chash.c b/src/lb_chash.c
index 32d7d1d1166f766da968e7c02fe03f99b3c42dc2..70a455dc3054dd2dd972eef44fc882c64305ce00 100644 (file)
--- a/src/lb_chash.c
+++ b/src/lb_chash.c
@@ -388,9 +388,11 @@ struct server *chash_get_next_server(struct proxy *p, struct server *srvtoavoid)
                        node = eb32_first(root);
 
                p->lbprm.chash.last = node;
-               if (!node)
+               if (!node) {
                        /* no node is available */
-                       return NULL;
+                       srv = NULL;
+                       goto out;
+               }
 
                /* Note: if we came here after a down/up cycle with no last
                 * pointer, and after a redispatch (srvtoavoid is set), we