]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/pf: Unify VF state tracking log
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Tue, 30 Sep 2025 23:35:22 +0000 (01:35 +0200)
committerMichal Wajdeczko <michal.wajdeczko@intel.com>
Thu, 2 Oct 2025 21:58:32 +0000 (23:58 +0200)
By using single function that dumps VF state transition, final
logs are easier to analyze as there is always the same call site
in every debug message.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: MichaƂ Winiarski <michal.winiarski@intel.com>
Link: https://lore.kernel.org/r/20250930233525.201263-5-michal.wajdeczko@intel.com
drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c

index e582f4d60015783872ec8260e8e6ea7d3e508d6c..90fb69b0e041b0db1c295b08291f3b95d852bf00 100644 (file)
@@ -271,12 +271,19 @@ static bool pf_expect_vf_not_state(struct xe_gt *gt, unsigned int vfid,
        return result;
 }
 
+static void pf_track_vf_state(struct xe_gt *gt, unsigned int vfid,
+                             enum xe_gt_sriov_control_bits bit,
+                             const char *what)
+{
+       xe_gt_sriov_dbg_verbose(gt, "VF%u state %s(%d) %s\n",
+                               vfid, control_bit_to_string(bit), bit, what);
+}
+
 static bool pf_enter_vf_state(struct xe_gt *gt, unsigned int vfid,
                              enum xe_gt_sriov_control_bits bit)
 {
        if (!test_and_set_bit(bit, pf_peek_vf_state(gt, vfid))) {
-               xe_gt_sriov_dbg_verbose(gt, "VF%u state %s(%d) enter\n",
-                                       vfid, control_bit_to_string(bit), bit);
+               pf_track_vf_state(gt, vfid, bit, "enter");
                return true;
        }
        return false;
@@ -286,8 +293,7 @@ static bool pf_exit_vf_state(struct xe_gt *gt, unsigned int vfid,
                             enum xe_gt_sriov_control_bits bit)
 {
        if (test_and_clear_bit(bit, pf_peek_vf_state(gt, vfid))) {
-               xe_gt_sriov_dbg_verbose(gt, "VF%u state %s(%d) exit\n",
-                                       vfid, control_bit_to_string(bit), bit);
+               pf_track_vf_state(gt, vfid, bit, "exit");
                return true;
        }
        return false;