interactive: explicitly `fflush` stdout before expecting input

At least one interactive command writes a prompt to `stdout` and then
reads user input on `stdin`: `git clean --interactive`. If the prompt is
left in the buffer, the user will not realize the program is waiting for
their input.

So let's just flush `stdout` before reading the user's input.

Signed-off-by: 마누엘 <nalla@hamal.uberspace.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/prompt.c b/prompt.c
index 098dcfb7cf94e6571902ea70c16b8d17a21a13ef..5ded21a017f1089c5a5f63c998c3b11631c0a5d6 100644 (file)
--- a/prompt.c
+++ b/prompt.c
@@ -77,8 +77,10 @@ char *git_prompt(const char *prompt, int flags)
 
 int git_read_line_interactively(struct strbuf *line)
 {
-       int ret = strbuf_getline_lf(line, stdin);
+       int ret;
 
+       fflush(stdout);
+       ret = strbuf_getline_lf(line, stdin);
        if (ret != EOF)
                strbuf_trim_trailing_newline(line);