]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:kdc: Check result of talloc_realloc()
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 21 Aug 2023 01:52:14 +0000 (13:52 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 14 Sep 2023 21:35:29 +0000 (21:35 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/kdc/pac-glue.c

index 44e3b931ee010f2c12fb9b4c095afb03f0a97220..7d8c2ff97b510a5aa9c6483b906b7e582946c883 100644 (file)
@@ -1349,6 +1349,12 @@ static NTSTATUS samba_kdc_update_delegation_info_blob(TALLOC_CTX *mem_ctx,
        d->proxy_target.string = server;
        d->transited_services = talloc_realloc(mem_ctx, d->transited_services,
                                               struct lsa_String, i + 1);
+       if (d->transited_services == NULL) {
+               SAFE_FREE(server);
+               SAFE_FREE(proxy);
+               talloc_free(tmp_ctx);
+               return NT_STATUS_INTERNAL_ERROR;
+       }
        d->transited_services[i].string = proxy;
        d->num_transited_services = i + 1;