]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
mips: align stack in clone [BZ #28223]
authorXi Ruoyao <xry111@mengyan1223.wang>
Thu, 12 Aug 2021 20:31:59 +0000 (20:31 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Thu, 12 Aug 2021 20:31:59 +0000 (20:31 +0000)
The MIPS O32 ABI requires 4 byte aligned stack, and the MIPS N64 and N32
ABI require 8 byte aligned stack.  Previously if the caller passed an
unaligned stack to clone the the child misbehaved.

Fixes bug 28223.

sysdeps/unix/sysv/linux/mips/clone.S

index 71d9dba8bd9e8f9e8a68e62e1bd2c5c6b358364a..43a5ad3a400d9504976f21c18e7ae4a9ea11a5c5 100644 (file)
@@ -55,6 +55,13 @@ NESTED(__clone,4*SZREG,sp)
        .set            at
 #endif
 
+       /* Align stack to 4/8 bytes per the ABI.  */
+#if _MIPS_SIM == _ABIO32
+       li              t0,-4
+#else
+       li              t0,-8
+#endif
+       and             a1,a1,t0
 
        /* Sanity check arguments.  */
        li              v0,EINVAL