net: phy: Refactor fwnode_get_phy_node()

Refactor to check if the fwnode we got is correct and return if so,
otherwise do additional checks. Using same pattern in all conditionals
makes it slightly easier to read and understand.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250430143802.3714405-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index f85c172c446c56e1da1d13baa18c581f2213dcc5..2eb735e68dd82f572dc8f3858bb0cf983b0a8343 100644 (file)
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -3265,12 +3265,12 @@ struct fwnode_handle *fwnode_get_phy_node(const struct fwnode_handle *fwnode)
 
        /* Only phy-handle is used for ACPI */
        phy_node = fwnode_find_reference(fwnode, "phy-handle", 0);
-       if (is_acpi_node(fwnode) || !IS_ERR(phy_node))
+       if (!IS_ERR(phy_node) || is_acpi_node(fwnode))
                return phy_node;
        phy_node = fwnode_find_reference(fwnode, "phy", 0);
-       if (IS_ERR(phy_node))
-               phy_node = fwnode_find_reference(fwnode, "phy-device", 0);
-       return phy_node;
+       if (!IS_ERR(phy_node))
+               return phy_node;
+       return fwnode_find_reference(fwnode, "phy-device", 0);
 }
 EXPORT_SYMBOL_GPL(fwnode_get_phy_node);