]> git.ipfire.org Git - people/ms/suricata.git/commitdiff
rfb: register None for get_event_info/get_event_info_by_id
authorJason Ish <jason.ish@oisf.net>
Wed, 18 Nov 2020 22:11:48 +0000 (16:11 -0600)
committerVictor Julien <victor@inliniac.net>
Wed, 1 Sep 2021 06:33:52 +0000 (08:33 +0200)
Implementations are not required if they're just going to return
-1. We allow None to be registered for that.

rust/src/rfb/rfb.rs

index 0059c7bd18cb8986fcf10145933ae024cbea7edb..da211cb7cfc5117e74cf58df70d8e13207f31fe7 100644 (file)
@@ -612,22 +612,6 @@ pub unsafe extern "C" fn rs_rfb_state_get_events(
     return tx.events;
 }
 
-#[no_mangle]
-pub extern "C" fn rs_rfb_state_get_event_info(
-    _event_name: *const std::os::raw::c_char,
-    _event_id: *mut std::os::raw::c_int,
-    _event_type: *mut core::AppLayerEventType,
-) -> std::os::raw::c_int {
-    return -1;
-}
-
-#[no_mangle]
-pub extern "C" fn rs_rfb_state_get_event_info_by_id(_event_id: std::os::raw::c_int,
-                                                         _event_name: *mut *const std::os::raw::c_char,
-                                                         _event_type: *mut core::AppLayerEventType
-) -> i8 {
-    return -1;
-}
 #[no_mangle]
 pub unsafe extern "C" fn rs_rfb_state_get_tx_iterator(
     _ipproto: u8,
@@ -683,8 +667,8 @@ pub unsafe extern "C" fn rs_rfb_register_parser() {
         get_de_state: rs_rfb_tx_get_detect_state,
         set_de_state: rs_rfb_tx_set_detect_state,
         get_events: Some(rs_rfb_state_get_events),
-        get_eventinfo: Some(rs_rfb_state_get_event_info),
-        get_eventinfo_byid : Some(rs_rfb_state_get_event_info_by_id),
+        get_eventinfo: None,
+        get_eventinfo_byid: None,
         localstorage_new: None,
         localstorage_free: None,
         get_files: None,