]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: qcom: disable GPU on x1e80100 by default
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 15 Jul 2024 19:17:44 +0000 (22:17 +0300)
committerBjorn Andersson <andersson@kernel.org>
Thu, 15 Aug 2024 02:33:42 +0000 (21:33 -0500)
The GPU on X1E80100 requires ZAP 'shader' file to be useful. Since the
file is signed by the OEM keys and might be not available by default,
disable the GPU node and drop the firmware name from the x1e80100.dtsi
file. Devices not being fused to use OEM keys can specify generic
location at `qcom/x1e80100/gen70500_zap.mbn` while enabling the GPU.

The CRD and QCP were lucky enough to work with the default settings, so
reenable the GPU on those platforms and provide correct firmware-name
(including the SoC subdir).

Fixes: 721e38301b79 ("arm64: dts: qcom: x1e80100: Add gpu support")
Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
Link: https://lore.kernel.org/r/20240715-x1e8-zap-name-v3-1-e7a5258c3c2e@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e80100-crd.dts
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
arch/arm64/boot/dts/qcom/x1e80100.dtsi

index 82f34dfe409057a6c30601bfe3ff229f5838b06c..e17ab8251e2a550d74ee0f899da89f5cd8531c32 100644 (file)
        };
 };
 
+&gpu {
+       status = "okay";
+
+       zap-shader {
+               firmware-name = "qcom/x1e80100/gen70500_zap.mbn";
+       };
+};
+
 &i2c0 {
        clock-frequency = <400000>;
 
index 2dcf2a17511dbfc1bd47042bf67e2c1da2ab390d..8098e6730ae52f0e29cc25b756aa4ea47e3c930e 100644 (file)
        };
 };
 
+&gpu {
+       status = "okay";
+
+       zap-shader {
+               firmware-name = "qcom/x1e80100/gen70500_zap.mbn";
+       };
+};
+
 &lpass_tlmm {
        spkr_01_sd_n_active: spkr-01-sd-n-active-state {
                pins = "gpio12";
index c13811a4ef909d21a236b0d324df14a4ee193307..29cb3dddbb6fa1d70dff095a65ffc8cdf0b23b8a 100644 (file)
                        interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>;
                        interconnect-names = "gfx-mem";
 
+                       status = "disabled";
+
                        zap-shader {
                                memory-region = <&gpu_microcode_mem>;
-                               firmware-name = "qcom/gen70500_zap.mbn";
                        };
 
                        gpu_opp_table: opp-table {