]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
vfs_ceph_new: avoid setting errno in cephmount_cache_update
authorShachar Sharon <ssharon@redhat.com>
Wed, 4 Sep 2024 12:59:21 +0000 (15:59 +0300)
committerAnoop C S <anoopcs@samba.org>
Sun, 3 Nov 2024 09:59:37 +0000 (09:59 +0000)
Do not set 'errno' to ENOENT in cephmount_cache_update. Setting this
errno value upon newly inserted entry may cause vfs_ceph_connect to
change errno to non-zero value even though the final result is OK.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15703

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
source3/modules/vfs_ceph_new.c

index dff761fb79629305e12d126c8762d9442931616a..4ad5fa19104f7d01eb7cc771d0357ae6ae03f8e6 100644 (file)
@@ -220,7 +220,6 @@ static struct cephmount_cached *cephmount_cache_update(const char *cookie)
                }
        }
 
-       errno = ENOENT;
        return NULL;
 }