]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mtd: mtdoops: Fix kmsgdump parameter renaming.
authorJocelyn Falempe <jfalempe@redhat.com>
Fri, 19 Jul 2024 15:24:13 +0000 (17:24 +0200)
committerJocelyn Falempe <jfalempe@redhat.com>
Mon, 22 Jul 2024 15:56:22 +0000 (17:56 +0200)
When the kmsg_dumper callback parameter changed, the reason variable
in mtdoops_do_dump() was not updated accordingly.
This breaks the build with mtdoops.

Fixes: e1a261ba599e ("printk: Add a short description string to kmsg_dump()")
Suggested-by: Knop Ryszard <ryszard.knop@intel.com>
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Acked-by: Richard Weinberger <richard@nod.at>
Link: https://patchwork.freedesktop.org/patch/msgid/20240719152542.1554440-1-jfalempe@redhat.com
drivers/mtd/mtdoops.c

index 86d49db9196d8f16d54eb675b72f827f1a9c267a..7bf3777e1f1374fd5fb4b6009f097182ab62179e 100644 (file)
@@ -305,7 +305,7 @@ static void mtdoops_do_dump(struct kmsg_dumper *dumper,
        struct kmsg_dump_iter iter;
 
        /* Only dump oopses if dump_oops is set */
-       if (reason == KMSG_DUMP_OOPS && !dump_oops)
+       if (detail->reason == KMSG_DUMP_OOPS && !dump_oops)
                return;
 
        kmsg_dump_rewind(&iter);
@@ -317,7 +317,7 @@ static void mtdoops_do_dump(struct kmsg_dumper *dumper,
                             record_size - sizeof(struct mtdoops_hdr), NULL);
        clear_bit(0, &cxt->oops_buf_busy);
 
-       if (reason != KMSG_DUMP_OOPS) {
+       if (detail->reason != KMSG_DUMP_OOPS) {
                /* Panics must be written immediately */
                mtdoops_write(cxt, 1);
        } else {