]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
datatype: don't return a const string from cgroupv2_get_path()
authorThomas Haller <thaller@redhat.com>
Tue, 24 Oct 2023 09:57:07 +0000 (11:57 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 9 Nov 2023 11:34:42 +0000 (12:34 +0100)
The caller is supposed to free the allocated string. Return a non-const
string to make that clearer.

Signed-off-by: Thomas Haller <thaller@redhat.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/datatype.c

index 64e4647a605f1331afdded81b35e0bfd0b85e0b8..6362735809f7a7efc7023384153217d2194ddfa5 100644 (file)
@@ -1465,10 +1465,10 @@ const struct datatype policy_type = {
 
 #define SYSFS_CGROUPSV2_PATH   "/sys/fs/cgroup"
 
-static const char *cgroupv2_get_path(const char *path, uint64_t id)
+static char *cgroupv2_get_path(const char *path, uint64_t id)
 {
-       const char *cgroup_path = NULL;
        char dent_name[PATH_MAX + 1];
+       char *cgroup_path = NULL;
        struct dirent *dent;
        struct stat st;
        DIR *d;
@@ -1506,7 +1506,7 @@ static void cgroupv2_type_print(const struct expr *expr,
                                struct output_ctx *octx)
 {
        uint64_t id = mpz_get_uint64(expr->value);
-       const char *cgroup_path;
+       char *cgroup_path;
 
        cgroup_path = cgroupv2_get_path(SYSFS_CGROUPSV2_PATH, id);
        if (cgroup_path)