]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
reset: rzg2l-usbphy-ctrl: Assign proper of node to the allocated device
authorClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Tue, 19 Nov 2024 08:55:54 +0000 (10:55 +0200)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Fri, 6 Dec 2024 15:51:28 +0000 (16:51 +0100)
The platform device named "rzg2l-usb-vbus-regulator", allocated by
the rzg2l-usbphy-ctrl driver, is used to instantiate a regulator driver.
This regulator driver is associated with a device tree (DT) node, which
is a child of the rzg2l-usbphy-ctrl DT node. The regulator's DT node allows
consumer nodes to reference the regulator and configure the regulator as
needed.

Starting with commit cd7a38c40b23 ("regulator: core: do not silently ignore
provided init_data") the struct regulator_dev::dev::of_node is no longer
populated using of_node_get(config->of_node) if the regulator does not
provide init_data. Since the rzg2l-usb-vbus-regulator does not provide
init_data, this behaviour causes the of_find_regulator_by_node() function
to fails, resulting in errors when attempting to request the regulator.

To fix this issue, call device_set_of_node_from_dev() for the
"rzg2l-usb-vbus-regulator" platform device.

Fixes: 84fbd6198766 ("regulator: Add Renesas RZ/G2L USB VBUS regulator driver")
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/20241119085554.1035881-1-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/reset-rzg2l-usbphy-ctrl.c

index 1cd157f4f03b4713ebee95cabe0f21d7c7f13933..4e2ac1f0060c0d0c4ce4c2b53ca3d3b2646c80c5 100644 (file)
@@ -176,6 +176,7 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev)
        vdev->dev.parent = dev;
        priv->vdev = vdev;
 
+       device_set_of_node_from_dev(&vdev->dev, dev);
        error = platform_device_add(vdev);
        if (error)
                goto err_device_put;