]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-smtp: smtp_server_connection_ssl_init() - Don't start SSL handshake
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Tue, 2 Mar 2021 15:51:54 +0000 (17:51 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Thu, 11 Mar 2021 11:19:09 +0000 (11:19 +0000)
If SSL handshaking fails, it shouldn't be logged as an error similarly to
actual SSL initialization errors.

src/lib-smtp/smtp-server-connection.c

index b5d7f7ff2b49dd69dd3a906cfcc081df7beb6816..bdca2d0717712ce133c2cab1d2122a334da3d208 100644 (file)
@@ -403,12 +403,6 @@ int smtp_server_connection_ssl_init(struct smtp_server_connection *conn)
        }
        smtp_server_connection_input_resume(conn);
 
-       if (ssl_iostream_handshake(conn->ssl_iostream) < 0) {
-               e_error(conn->event, "SSL handshake failed: %s",
-                       ssl_iostream_get_last_error(conn->ssl_iostream));
-               return -1;
-       }
-
        conn->ssl_secured = TRUE;
        conn->set.capabilities &= ENUM_NEGATE(SMTP_CAPABILITY_STARTTLS);