]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:printing: Add missing newlines to logging messages
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 7 Aug 2023 04:47:10 +0000 (16:47 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 8 Aug 2023 04:39:38 +0000 (04:39 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/printing/print_cups.c
source3/printing/print_iprint.c
source3/printing/printer_list.c
source3/printing/printing.c

index 4d83d398675320fa7be5839360ec68aaa8e68794..d8ba9ccd011ca82413f442f9b3118ea7442ffe79 100644 (file)
@@ -1107,7 +1107,7 @@ static int cups_job_submit(int snum, struct printjob *pjob,
                                pjob->sysjob = ippGetInteger(attr_job_id, 0);
                                DEBUG(5,("cups_job_submit: job-id %d\n", pjob->sysjob));
                        } else {
-                               DEBUG(0,("Missing job-id attribute in IPP response"));
+                               DEBUG(0,("Missing job-id attribute in IPP response\n"));
                        }
                }
        } else {
@@ -1301,7 +1301,7 @@ static int cups_queue_get(const char *sharename,
                        queue = SMB_REALLOC_ARRAY(queue, print_queue_struct, qalloc);
 
                        if (queue == NULL) {
-                               DEBUG(0,("cups_queue_get: Not enough memory!"));
+                               DEBUG(0,("cups_queue_get: Not enough memory!\n"));
                                qcount = 0;
                                goto out;
                        }
index 6600d954dedd691a6c144495b6d3bfadbe286173..2b2215eb8c3fc9ce5d01de880903dce7eb3420e8 100644 (file)
@@ -1205,7 +1205,7 @@ static int iprint_queue_get(const char *sharename,
                        queue = SMB_REALLOC_ARRAY(queue, print_queue_struct, qalloc);
 
                        if (queue == NULL) {
-                               DEBUG(0,("iprint_queue_get: Not enough memory!"));
+                               DEBUG(0,("iprint_queue_get: Not enough memory!\n"));
                                qcount = 0;
                                goto out;
                        }
index 8ff75dc6bdd17c9491063d0f39034cb24ba7834d..3430d2b7d17ce621fc92cc91ae1b7537cd85008b 100644 (file)
@@ -98,7 +98,7 @@ NTSTATUS printer_list_get_printer(TALLOC_CTX *mem_ctx,
                         PL_DATA_FORMAT,
                         &time_h, &time_l, &nstr, &cstr, &lstr);
        if (ret == -1) {
-               DEBUG(1, ("Failed to un pack printer data"));
+               DEBUG(1, ("Failed to un pack printer data\n"));
                status = NT_STATUS_INTERNAL_DB_CORRUPTION;
                goto done;
        }
@@ -249,7 +249,7 @@ NTSTATUS printer_list_get_last_refresh(time_t *last_refresh)
                         PL_TSTAMP_FORMAT, &time_h, &time_l);
        TALLOC_FREE(data.dptr);
        if (ret == -1) {
-               DEBUG(1, ("Failed to un pack printer data"));
+               DEBUG(1, ("Failed to un pack printer data\n"));
                status = NT_STATUS_INTERNAL_DB_CORRUPTION;
                goto done;
        }
@@ -354,7 +354,7 @@ static int printer_list_clean_fn(struct db_record *rec, void *private_data)
                         PL_DATA_FORMAT, &time_h, &time_l, &name, &comment,
                         &location);
        if (ret == -1) {
-               DEBUG(1, ("Failed to un pack printer data"));
+               DEBUG(1, ("Failed to un pack printer data\n"));
                state->status = NT_STATUS_INTERNAL_DB_CORRUPTION;
                return -1;
        }
@@ -427,7 +427,7 @@ static int printer_list_exec_fn(struct db_record *rec, void *private_data)
                         PL_DATA_FORMAT, &time_h, &time_l, &name, &comment,
                         &location);
        if (ret == -1) {
-               DEBUG(1, ("Failed to un pack printer data"));
+               DEBUG(1, ("Failed to un pack printer data\n"));
                state->status = NT_STATUS_INTERNAL_DB_CORRUPTION;
                return -1;
        }
index 5cf170d4daece48266136d56bc7c8cfb0a590d1b..9d7cd55c05c9ea16a7aab615024290d50a8e5009 100644 (file)
@@ -2097,7 +2097,7 @@ WERROR print_job_delete(const struct auth_session_info *server_info,
            !W_ERROR_IS_OK(print_access_check(server_info, msg_ctx, snum,
                                              JOB_ACCESS_ADMINISTER))) {
                DEBUG(0, ("print job delete denied."
-                         "User name: %s, Printer name: %s.",
+                         "User name: %s, Printer name: %s.\n",
                          uidtoname(server_info->unix_token->uid),
                          lp_printername(tmp_ctx, lp_sub, snum)));
 
@@ -2184,7 +2184,7 @@ WERROR print_job_pause(const struct auth_session_info *server_info,
            !W_ERROR_IS_OK(print_access_check(server_info, msg_ctx, snum,
                                              JOB_ACCESS_ADMINISTER))) {
                DEBUG(0, ("print job pause denied."
-                         "User name: %s, Printer name: %s.",
+                         "User name: %s, Printer name: %s.\n",
                          uidtoname(server_info->unix_token->uid),
                          lp_printername(tmp_ctx, lp_sub, snum)));
 
@@ -2253,7 +2253,7 @@ WERROR print_job_resume(const struct auth_session_info *server_info,
            !W_ERROR_IS_OK(print_access_check(server_info, msg_ctx, snum,
                                              JOB_ACCESS_ADMINISTER))) {
                DEBUG(0, ("print job resume denied."
-                         "User name: %s, Printer name: %s.",
+                         "User name: %s, Printer name: %s.\n",
                          uidtoname(server_info->unix_token->uid),
                          lp_printername(tmp_ctx, lp_sub, snum)));