lib/addgrps.c: add_groups(): Allocate earlier

This will allow using lsearch(3).

Reviewed-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>

diff --git a/lib/addgrps.c b/lib/addgrps.c
index 0a38d861bc98cd9cf5b9e1783744e02f89fb4079..b64fa4978d85f43717ffd9351764b74c32c17b83 100644 (file)
--- a/lib/addgrps.c
+++ b/lib/addgrps.c
@@ -70,6 +70,10 @@ add_groups(const char *list)
                        continue;
                }
 
+               grouplist = REALLOCF(grouplist, ngroups + 1, GETGROUPS_T);
+               if (grouplist == NULL)
+                       return -1;
+
                if (LFIND(&grp->gr_gid, grouplist, ngroups) != NULL)
                        continue;
 
@@ -77,10 +81,7 @@ add_groups(const char *list)
                        fputs (_("Warning: too many groups\n"), shadow_logfd);
                        break;
                }
-               grouplist = REALLOCF(grouplist, ngroups + 1, GETGROUPS_T);
-               if (grouplist == NULL) {
-                       return -1;
-               }
+
                grouplist[ngroups] = grp->gr_gid;
                ngroups++;
                added = true;