]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
login-proxy: Remove dead code checking if client is destroyed
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Thu, 9 Apr 2020 20:08:39 +0000 (23:08 +0300)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Fri, 24 Apr 2020 08:02:40 +0000 (08:02 +0000)
The beginning of the function already assert-crashes if client is destroyed
and nothing in the code path can destroy the client.

src/login-common/client-common-auth.c

index 15f1dcccfc39579c102b5e3a9b896612c0f36fa4..75deabda5c24214fc261b6f9223d8aeb970d0645 100644 (file)
@@ -422,11 +422,6 @@ static int proxy_start(struct client *client,
 
        i_assert(client->refcount > 1);
 
-       if (client->destroyed) {
-               /* connection_queue_add() decided that we were the oldest
-                  connection and killed us. */
-               return -1;
-       }
        if (login_proxy_is_ourself(client, reply->host, reply->port,
                                   reply->destuser)) {
                e_error(client->event, "Proxying loops to itself");