]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
optee: fix format string for printing optee build_id
authorSahil Malhotra <sahil.malhotra@nxp.com>
Fri, 29 Nov 2024 11:46:48 +0000 (12:46 +0100)
committerJens Wiklander <jens.wiklander@linaro.org>
Tue, 17 Dec 2024 10:22:46 +0000 (11:22 +0100)
There has been a recent change in OP-TEE to print 8 and 16 character
commit id for 32bit and 64bit architecture respectively.
In case if commit id is starting with 0 like 04d1c612ec7beaede073b8c
it is printing revision as below removing leading 0
"optee: revision 4.4 (4d1c612ec7beaed)"

Signed-off-by: Sahil Malhotra <sahil.malhotra@nxp.com>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Link: https://lore.kernel.org/r/20241129114648.3048941-1-sahil.malhotra@nxp.com
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/tee/optee/smc_abi.c

index 3e33cf2af73bbfed28cf61757deef294e65db416..f0c3ac1103bb5f6de0f2bb79ab24622cd0174a7c 100644 (file)
@@ -1272,8 +1272,9 @@ static void optee_msg_get_os_revision(optee_invoke_fn *invoke_fn)
                  &res.smccc);
 
        if (res.result.build_id)
-               pr_info("revision %lu.%lu (%08lx)", res.result.major,
-                       res.result.minor, res.result.build_id);
+               pr_info("revision %lu.%lu (%0*lx)", res.result.major,
+                       res.result.minor, (int)sizeof(res.result.build_id) * 2,
+                       res.result.build_id);
        else
                pr_info("revision %lu.%lu", res.result.major, res.result.minor);
 }