]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd/pm: Add xgmi plpd to SMU v13.0.6 pm_policy
authorLijo Lazar <lijo.lazar@amd.com>
Mon, 4 Mar 2024 06:19:08 +0000 (11:49 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 17 May 2024 21:40:39 +0000 (17:40 -0400)
On SOCs with SMU v13.0.6, allow changing xgmi plpd policy through
'pm_policy/xgmi_plpd' sysfs interface.

Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Asad Kamal <asad.kamal@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h

index 5c4062630c3b17ab5362acd3558f1b8da5c810f6..15ad2d426c1619c88e6163b9d377b8b05230c7fc 100644 (file)
@@ -1197,6 +1197,9 @@ static void smu_swctf_delayed_work_handler(struct work_struct *work)
 
 static void smu_init_xgmi_plpd_mode(struct smu_context *smu)
 {
+       struct smu_dpm_context *dpm_ctxt = &(smu->smu_dpm);
+       struct smu_dpm_policy_ctxt *policy_ctxt;
+
        if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(11, 0, 2)) {
                smu->plpd_mode = XGMI_PLPD_DEFAULT;
                return;
@@ -1204,10 +1207,20 @@ static void smu_init_xgmi_plpd_mode(struct smu_context *smu)
 
        /* PMFW put PLPD into default policy after enabling the feature */
        if (smu_feature_is_enabled(smu,
-                                  SMU_FEATURE_XGMI_PER_LINK_PWR_DWN_BIT))
+                                  SMU_FEATURE_XGMI_PER_LINK_PWR_DWN_BIT)) {
+               struct smu_dpm_policy *policy;
+
                smu->plpd_mode = XGMI_PLPD_DEFAULT;
-       else
+               policy = smu_get_pm_policy(smu, PP_PM_POLICY_XGMI_PLPD);
+               if (policy)
+                       policy->current_level = XGMI_PLPD_DEFAULT;
+       } else {
                smu->plpd_mode = XGMI_PLPD_NONE;
+               policy_ctxt = dpm_ctxt->dpm_policies;
+               if (policy_ctxt)
+                       policy_ctxt->policy_mask &=
+                               ~BIT(PP_PM_POLICY_XGMI_PLPD);
+       }
 }
 
 static int smu_sw_init(void *handle)
index 9351e7896822f6cca2bc90362b06b84f0d22a5b4..ceb2174baff67203b1028d12a3481b1386c7529a 100644 (file)
@@ -403,9 +403,45 @@ static int smu_v13_0_6_select_policy_soc_pstate(struct smu_context *smu,
        return ret;
 }
 
+static int smu_v13_0_6_select_plpd_policy(struct smu_context *smu, int level)
+{
+       struct amdgpu_device *adev = smu->adev;
+       int ret, param;
+
+       switch (level) {
+       case XGMI_PLPD_DEFAULT:
+               param = PPSMC_PLPD_MODE_DEFAULT;
+               break;
+       case XGMI_PLPD_OPTIMIZED:
+               param = PPSMC_PLPD_MODE_OPTIMIZED;
+               break;
+       case XGMI_PLPD_DISALLOW:
+               param = 0;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       if (level == XGMI_PLPD_DISALLOW)
+               ret = smu_cmn_send_smc_msg_with_param(
+                       smu, SMU_MSG_GmiPwrDnControl, param, NULL);
+       else
+               /* change xgmi per-link power down policy */
+               ret = smu_cmn_send_smc_msg_with_param(
+                       smu, SMU_MSG_SelectPLPDMode, param, NULL);
+
+       if (ret)
+               dev_err(adev->dev,
+                       "select xgmi per-link power down policy %d failed\n",
+                       level);
+
+       return ret;
+}
+
 static int smu_v13_0_6_allocate_dpm_context(struct smu_context *smu)
 {
        struct smu_dpm_context *smu_dpm = &smu->smu_dpm;
+       struct smu_dpm_policy *policy;
 
        smu_dpm->dpm_context =
                kzalloc(sizeof(struct smu_13_0_dpm_context), GFP_KERNEL);
@@ -413,11 +449,9 @@ static int smu_v13_0_6_allocate_dpm_context(struct smu_context *smu)
                return -ENOMEM;
        smu_dpm->dpm_context_size = sizeof(struct smu_13_0_dpm_context);
 
+       smu_dpm->dpm_policies =
+               kzalloc(sizeof(struct smu_dpm_policy_ctxt), GFP_KERNEL);
        if (!(smu->adev->flags & AMD_IS_APU)) {
-               struct smu_dpm_policy *policy;
-
-               smu_dpm->dpm_policies =
-                       kzalloc(sizeof(struct smu_dpm_policy_ctxt), GFP_KERNEL);
                policy = &(smu_dpm->dpm_policies->policies[0]);
 
                policy->policy_type = PP_PM_POLICY_SOC_PSTATE;
@@ -430,6 +464,15 @@ static int smu_v13_0_6_allocate_dpm_context(struct smu_context *smu)
                smu_dpm->dpm_policies->policy_mask |=
                        BIT(PP_PM_POLICY_SOC_PSTATE);
        }
+       policy = &(smu_dpm->dpm_policies->policies[1]);
+
+       policy->policy_type = PP_PM_POLICY_XGMI_PLPD;
+       policy->level_mask = BIT(XGMI_PLPD_DISALLOW) | BIT(XGMI_PLPD_DEFAULT) |
+                            BIT(XGMI_PLPD_OPTIMIZED);
+       policy->current_level = XGMI_PLPD_DEFAULT;
+       policy->set_policy = smu_v13_0_6_select_plpd_policy;
+       smu_cmn_generic_plpd_policy_desc(policy);
+       smu_dpm->dpm_policies->policy_mask |= BIT(PP_PM_POLICY_XGMI_PLPD);
 
        return 0;
 }
index 50fe9feaf80d1d85f84b5c338837fa203806b736..f265a449c342bc789e22fb5b424d067aba77b28d 100644 (file)
@@ -1165,3 +1165,30 @@ void smu_cmn_generic_soc_policy_desc(struct smu_dpm_policy *policy)
        policy->desc = &pstate_policy_desc;
 }
 
+static char *smu_xgmi_plpd_policy_get_desc(struct smu_dpm_policy *policy,
+                                          int level)
+{
+       if (level < 0 || !(policy->level_mask & BIT(level)))
+               return "Invalid";
+
+       switch (level) {
+       case XGMI_PLPD_DISALLOW:
+               return "plpd_disallow";
+       case XGMI_PLPD_DEFAULT:
+               return "plpd_default";
+       case XGMI_PLPD_OPTIMIZED:
+               return "plpd_optimized";
+       }
+
+       return "Invalid";
+}
+
+static struct smu_dpm_policy_desc xgmi_plpd_policy_desc = {
+       .name = STR_XGMI_PLPD_POLICY,
+       .get_desc = smu_xgmi_plpd_policy_get_desc,
+};
+
+void smu_cmn_generic_plpd_policy_desc(struct smu_dpm_policy *policy)
+{
+       policy->desc = &xgmi_plpd_policy_desc;
+}
index d135d984329e3366db4812dbe6d06a7ed512c092..1de685defe85b19e3d2895ec33a2e95101c8ded8 100644 (file)
@@ -145,6 +145,7 @@ static inline void smu_cmn_get_sysfs_buf(char **buf, int *offset)
 
 bool smu_cmn_is_audio_func_enabled(struct amdgpu_device *adev);
 void smu_cmn_generic_soc_policy_desc(struct smu_dpm_policy *policy);
+void smu_cmn_generic_plpd_policy_desc(struct smu_dpm_policy *policy);
 
 #endif
 #endif