]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
github: fix quoting in github workflow for jitter tests
authorDimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
Wed, 31 Jul 2024 10:01:35 +0000 (11:01 +0100)
committerNeil Horman <nhorman@openssl.org>
Mon, 5 Aug 2024 16:54:21 +0000 (12:54 -0400)
Nested quoting got ignore previously. And this way one can specify
string name directly.

Successfully run with Jitter at
https://github.com/xnox/openssl/actions/runs/10223149419/job/28289017013

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/25053)

.github/workflows/run-checker-daily.yml
crypto/rand/rand_lib.c
doc/man3/RAND_set_DRBG_type.pod
doc/man7/EVP_RAND.pod

index 2489fc0cb196f6f08edd839642cd3f1e8dce288d..f4af3eb9a8a7a35e939bbf56d267440834793883 100644 (file)
@@ -207,7 +207,7 @@ jobs:
     - name: checkout fuzz/corpora submodule
       run: git submodule update --init --depth 1 fuzz/corpora
     - name: config
-      run: ./config --with-rand-seed=none enable-jitter --with-jitter-include=jitter/ --with-jitter-lib=jitter/ -DOPENSSL_DEFAULT_SEED_SRC='"JITTER"' && perl configdata.pm --dump
+      run: ./config --with-rand-seed=none enable-jitter --with-jitter-include=jitter/ --with-jitter-lib=jitter/ -DOPENSSL_DEFAULT_SEED_SRC=JITTER && perl configdata.pm --dump
     - name: make
       run: make -s -j4
     - name: get cpu info
index 9ebfe7b1d2971b8ad971131c23b1a288501942b7..e692fe7534f5e140a6da0afd311de93a5248aee8 100644 (file)
@@ -21,7 +21,7 @@
 #include "crypto/context.h"
 
 #ifndef OPENSSL_DEFAULT_SEED_SRC
-# define OPENSSL_DEFAULT_SEED_SRC "SEED-SRC"
+# define OPENSSL_DEFAULT_SEED_SRC SEED-SRC
 #endif
 
 #ifndef FIPS_MODULE
@@ -597,7 +597,7 @@ static EVP_RAND_CTX *rand_new_seed(OSSL_LIB_CTX *libctx)
                 propq = props;
             }
         }
-        name = OPENSSL_DEFAULT_SEED_SRC;
+        name = OPENSSL_MSTR(OPENSSL_DEFAULT_SEED_SRC);
     }
 
     rand = EVP_RAND_fetch(libctx, name, propq);
index 92fcaf74bd2f940b61ee33b3455b4e8935555424..cf89075096c65c2bcc15b74fdf93f433b7ad3075 100644 (file)
@@ -42,7 +42,7 @@ is made too late.
 The default DRBG is "CTR-DRBG" using the "AES-256-CTR" cipher.
 
 The default seed source can be configured when OpenSSL is compiled by
-setting B<-DOPENSSL_DEFAULT_SEED_SRC='\"SEED-SRC\"'>. If not set then
+setting B<-DOPENSSL_DEFAULT_SEED_SRC=SEED-SRC>. If not set then
 "SEED-SRC" is used.
 
 =head1 EXAMPLES
index d80497f98e6077e7c14456a8d99d0a571070aeb0..701ea1bcc79abd7b34012d3361a84de5af7d7e5b 100644 (file)
@@ -226,9 +226,9 @@ but also for every generate request.
 In most cases OpenSSL will automatically choose a suitable seed source
 for automatically seeding and reseeding its <primary> DRBG. The
 default seed source can be configured when OpenSSL is compiled by
-setting B<-DOPENSSL_DEFAULT_SEED_SRC='\"SEED-SRC\"'>. If not set then
+setting B<-DOPENSSL_DEFAULT_SEED_SRC=SEED-SRC>. If not set then
 "SEED-SRC" is used. One can specify a third-party provider seed-source,
-or B<-DOPENSSL_DEFAULT_SEED_SRC='\"JITTER\"'> if available.
+or B<-DOPENSSL_DEFAULT_SEED_SRC=JITTER> if available.
 
 In some cases however, it will be necessary to explicitly specify a
 seed source used by "SEED-SRC" during configuration, using the