]> git.ipfire.org Git - thirdparty/sarg.git/commitdiff
Add a limit on the size of some string generated with sprintf
authorFrederic Marchal <fmarchal@users.sourceforge.net>
Sun, 7 Jun 2015 19:08:11 +0000 (21:08 +0200)
committerFrederic Marchal <fmarchal@users.sourceforge.net>
Sun, 7 Jun 2015 19:08:11 +0000 (21:08 +0200)
This is to avoid a buffer overflow.

useragent.c

index 8d649d49baa351bb901f9ba46eb69042d5929b73..015024b30e939ca24948cf31b7b86ef3e3da8ebc 100644 (file)
@@ -63,9 +63,8 @@ void useragent(void)
        ipbefore[0]='\0';
        namebefore[0]='\0';
 
-       sprintf(tmp3,"%s/squagent.int_unsort",tmp);
-       sprintf(tmp2,"%s/squagent.int_log",tmp);
-
+       snprintf(tmp3,sizeof(tmp3),"%s/squagent.int_unsort",tmp);
+       snprintf(tmp2,sizeof(tmp2),"%s/squagent.int_log",tmp);
 
        if((fp_ou=fopen(tmp3,"w"))==NULL) {
                debuga(__FILE__,__LINE__,_("Cannot open file \"%s\": %s\n"),tmp3,strerror(errno));