fast-import: remove dead strbuf

The strbuf in `note_change_n` is to copy the remainder of `p` before
potentially invalidating it when reading the next line. However, `p` is
not used after that point. It has been unused since the function was
created in a8dd2e7d2b (fast-import: Add support for importing commit
notes, 2009-10-09) and looks to be a fossil from adapting
`file_change_m`. Remove it.

Signed-off-by: Thalia Archibald <thalia@archibald.dev>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/fast-import.c b/builtin/fast-import.c
index c8a1e3ef3d825ce230d586791530934dc17032ae..832d0055f9c9098e9ddbf638f7e780516a0b4a7f 100644 (file)
--- a/builtin/fast-import.c
+++ b/builtin/fast-import.c
@@ -2448,7 +2448,6 @@ static void file_change_cr(const char *p, struct branch *b, int rename)
 
 static void note_change_n(const char *p, struct branch *b, unsigned char *old_fanout)
 {
-       static struct strbuf uq = STRBUF_INIT;
        struct object_entry *oe;
        struct branch *s;
        struct object_id oid, commit_oid;
@@ -2513,10 +2512,6 @@ static void note_change_n(const char *p, struct branch *b, unsigned char *old_fa
                die("Invalid ref name or SHA1 expression: %s", p);
 
        if (inline_data) {
-               if (p != uq.buf) {
-                       strbuf_addstr(&uq, p);
-                       p = uq.buf;
-               }
                read_next_command();
                parse_and_store_blob(&last_blob, &oid, 0);
        } else if (oe) {