lib: Assert-crash in i_close_fd() if fd == 0

lib-master now guarantees that fd==0 doesn't normally happen.

diff --git a/src/lib/macros.h b/src/lib/macros.h
index 593ca49d44c9125231dbc3af76e2d84acc0cfa70..36eb1584c22a15a8c92577168ac172ab8c4ccbbe 100644 (file)
--- a/src/lib/macros.h
+++ b/src/lib/macros.h
@@ -208,8 +208,11 @@
 
 #endif
 
+/* Close the fd and set it to -1. This assert-crashes if fd == 0. Normally
+   this would happen only if an uninitialized fd is attempted to be closed,
+   which is a bug. */
 #define i_close_fd(fd) STMT_START {  \
-       i_assert(*fd != -1); \
+       i_assert(*fd > 0); \
        if (unlikely(close_keep_errno(fd) < 0)) \
                i_error("close(%d[%s:%d]) failed: %m", \
                        *(fd), __FILE__, __LINE__); \