net: txgbe: fix null pointer to pcs

For 1000BASE-X or SGMII interface mode, the PCS also need to be selected.
Only return null pointer when there is a copper NIC with external PHY.

Fixes: 02b2a6f91b90 ("net: txgbe: support copper NIC with external PHY")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Link: https://patch.msgid.link/20241115073508.1130046-1-jiawenwu@trustnetic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
index 67b61afdde96ce31256196265e83b1c90b3a25ce..2e666f65aa825a3588f4038dabfb4a5a3babf1a9 100644 (file)
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
@@ -162,7 +162,7 @@ static struct phylink_pcs *txgbe_phylink_mac_select(struct phylink_config *confi
        struct wx *wx = phylink_to_wx(config);
        struct txgbe *txgbe = wx->priv;
 
-       if (interface == PHY_INTERFACE_MODE_10GBASER)
+       if (wx->media_type != sp_media_copper)
                return &txgbe->xpcs->pcs;
 
        return NULL;