channel.c: MOH is not working for transferee after attended transfer

Updated the code to check to see if MOH is playing on the transferor and if
so then start it on the channel that replaces it during a masquerade.

Example scenario of the problem:
Alice calls Bob and then Bob begins the attended transfer process into a queue.
Upon going on hold Alice hears music and so does Bob once he is in the queue.
Bob then transfers Alice into the queue and then music for Alice stops even
though she should be hearing it since has now replaced Bob in the queue.

The problem that was occurring is that once the channel was masqueraded the app
(queues, confbridge, etc...) had no way of knowing that the channel had just
been swapped out thus it did not start music for the present channel.

Credit to Olle Johansson for pointing me in the right direction on this issue.

(closes issue ASTERISK-19499)
Reported by: Timo Teräs
Review: https://reviewboard.asterisk.org/r/3226/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@408642 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 1b7dd8461d8ef65613b09a50f93ff5cf7e83b44f..543a3627d5e55fec4003285e07b3309213dab758 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -22445,7 +22445,9 @@ static int attempt_transfer(struct sip_dual *transferer, struct sip_dual *target
 
        if (peera && peerb && peerc && (peerb != peerc)) {
                ast_quiet_chan(peera);          /* Stop generators */
-               ast_quiet_chan(peerb);  
+               /* no need to quiet peerb since it should be hungup after the
+                  transfer and the masquerade needs to be able to see if MOH is
+                  playing on it */
                ast_quiet_chan(peerc);
                if (peerd)
                        ast_quiet_chan(peerd);
@@ -24048,7 +24050,6 @@ static int local_attended_transfer(struct sip_pvt *transferer, struct sip_dual *
 
                ast_do_masquerade(target.chan1);
 
-               ast_indicate(target.chan1, AST_CONTROL_UNHOLD);
                if (target.chan2) {
                        ast_indicate(target.chan2, AST_CONTROL_UNHOLD);
                }

diff --git a/main/channel.c b/main/channel.c
index b923649e429006e77b0e24dc34e5772fb64130f4..e7280f9de3085dcba315f282137279bbe74498b2 100644 (file)
--- a/main/channel.c
+++ b/main/channel.c
@@ -6532,6 +6532,7 @@ int ast_do_masquerade(struct ast_channel *original)
        unsigned int orig_disablestatecache;
        unsigned int clone_disablestatecache;
        int visible_indication;
+       int moh_is_playing;
        int clone_was_zombie = 0;/*!< TRUE if the clonechan was a zombie before the masquerade. */
        struct ast_frame *current;
        const struct ast_channel_tech *t;
@@ -6625,6 +6626,8 @@ int ast_do_masquerade(struct ast_channel *original)
                xfer_colp = NULL;
        }
 
+       moh_is_playing = ast_test_flag(original, AST_FLAG_MOH);
+
        /*
         * Stop any visible indication on the original channel so we can
         * transfer it to the clonechan taking the original's place.
@@ -6949,6 +6952,12 @@ int ast_do_masquerade(struct ast_channel *original)
                ast_indicate(original, visible_indication);
        }
 
+       /* if moh is playing on the original channel then it needs to be
+          maintained on the channel that is replacing it. */
+       if (moh_is_playing) {
+               ast_moh_start(original, NULL, NULL);
+       }
+
        ast_channel_lock(original);
 
        /* Signal any blocker */