]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nfc: st21nfca: Drop unneeded null check in st21nfca_tx_work()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sat, 4 Jan 2025 14:20:43 +0000 (15:20 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 7 Jan 2025 00:49:29 +0000 (16:49 -0800)
Variable 'info' is obtained via container_of() of struct work_struct, so
it cannot be NULL.  Simplify the code and solve Smatch warning:

  drivers/nfc/st21nfca/dep.c:119 st21nfca_tx_work() warn: can 'info' even be NULL?

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250104142043.116045-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/st21nfca/dep.c

index 1ec651e31064b128954045a63a2418474e5336b5..3425b68f0ddcfe55afda814d2f065303dffdfa1d 100644 (file)
@@ -116,18 +116,16 @@ static void st21nfca_tx_work(struct work_struct *work)
        struct nfc_dev *dev;
        struct sk_buff *skb;
 
-       if (info) {
-               dev = info->hdev->ndev;
-               skb = info->dep_info.tx_pending;
+       dev = info->hdev->ndev;
+       skb = info->dep_info.tx_pending;
 
-               device_lock(&dev->dev);
+       device_lock(&dev->dev);
 
-               nfc_hci_send_cmd_async(info->hdev, ST21NFCA_RF_READER_F_GATE,
-                               ST21NFCA_WR_XCHG_DATA, skb->data, skb->len,
-                               info->async_cb, info);
-               device_unlock(&dev->dev);
-               kfree_skb(skb);
-       }
+       nfc_hci_send_cmd_async(info->hdev, ST21NFCA_RF_READER_F_GATE,
+                       ST21NFCA_WR_XCHG_DATA, skb->data, skb->len,
+                       info->async_cb, info);
+       device_unlock(&dev->dev);
+       kfree_skb(skb);
 }
 
 static void st21nfca_im_send_pdu(struct st21nfca_hci_info *info,