]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath10k: fix QCOM_RPROC_COMMON dependency
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fri, 17 May 2024 07:00:28 +0000 (10:00 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 20 May 2024 11:48:34 +0000 (14:48 +0300)
If ath10k_snoc is built-in, while Qualcomm remoteprocs are built as
modules, compilation fails with:

/usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in function `ath10k_modem_init':
drivers/net/wireless/ath/ath10k/snoc.c:1534: undefined reference to `qcom_register_ssr_notifier'
/usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in function `ath10k_modem_deinit':
drivers/net/wireless/ath/ath10k/snoc.c:1551: undefined reference to `qcom_unregister_ssr_notifier'

Add corresponding dependency to ATH10K_SNOC Kconfig entry so that it's
built as module if QCOM_RPROC_COMMON is built as module too.

Fixes: 747ff7d3d742 ("ath10k: Don't always treat modem stop events as crashes")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240511-ath10k-snoc-dep-v1-1-9666e3af5c27@linaro.org
drivers/net/wireless/ath/ath10k/Kconfig

index e6ea884cafc190ac1bcbbf15d80823896e259572..4f385f4a8cef2acfc6f7aece9f703c6b8b46eabc 100644 (file)
@@ -45,6 +45,7 @@ config ATH10K_SNOC
        depends on ATH10K
        depends on ARCH_QCOM || COMPILE_TEST
        depends on QCOM_SMEM
+       depends on QCOM_RPROC_COMMON || QCOM_RPROC_COMMON=n
        select QCOM_SCM
        select QCOM_QMI_HELPERS
        help