]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: tegra210-quad: add rate limiting and simplify timeout error message
authorBreno Leitao <leitao@debian.org>
Tue, 1 Apr 2025 13:47:50 +0000 (06:47 -0700)
committerMark Brown <broonie@kernel.org>
Tue, 15 Apr 2025 18:48:25 +0000 (19:48 +0100)
On malfunctioning hardware, timeout error messages can appear thousands
of times, creating unnecessary system pressure and log bloat. This patch
makes two improvements:

1. Replace dev_err() with dev_err_ratelimited() to prevent log flooding
   when hardware errors persist
2. Remove the redundant timeout value parameter from the error message,
   as 'ret' is always zero in this error path

These changes reduce logging overhead while maintaining necessary error
reporting for debugging purposes.

Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20250401-tegra-v2-2-126c293ec047@debian.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra210-quad.c

index 2d320fbb8875f0c6936242bb0b911442b9ce8c3f..64e1b2f8a0001cfe0814a2c83600432d2fb389eb 100644 (file)
@@ -1118,8 +1118,8 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi,
                                        QSPI_DMA_TIMEOUT);
 
                        if (WARN_ON_ONCE(ret == 0)) {
-                               dev_err(tqspi->dev, "QSPI Transfer failed with timeout: %d\n",
-                                       ret);
+                               dev_err_ratelimited(tqspi->dev,
+                                                   "QSPI Transfer failed with timeout\n");
                                if (tqspi->is_curr_dma_xfer &&
                                    (tqspi->cur_direction & DATA_DIR_TX))
                                        dmaengine_terminate_all