]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib: Simplify timing_add_usecs
authorAki Tuomi <aki.tuomi@dovecot.fi>
Wed, 23 Aug 2017 10:42:09 +0000 (13:42 +0300)
committerTimo Sirainen <tss@dovecot.fi>
Thu, 7 Sep 2017 08:40:31 +0000 (11:40 +0300)
i_rand is guaranteed to return 32 bit integer

src/lib/timing.c

index 960db8492e7c18a0bff46dd6e385952887e81657..8b80ab290677d3711cba0bd2eb8b23369f71bfeb 100644 (file)
@@ -39,12 +39,7 @@ void timing_add_usecs(struct timing *timing, uint64_t usecs)
                if (timing->count == 0)
                        timing->min = timing->max = usecs;
        } else {
-               unsigned int count = timing->count;
-               unsigned int idx;
-               if (count > RAND_MAX >> 6)
-                       idx = (i_rand()*((uint64_t)RAND_MAX+1) + i_rand()) % count;
-               else
-                       idx = i_rand() % count;
+               unsigned int idx = i_rand() % timing->count;
                if (idx < TIMING_SUBSAMPLING_BUFFER)
                        timing->samples[idx] = usecs;
        }