]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: nfc: nci: Increase NCI_DATA_TIMEOUT to 3000 ms
authorJuraj Šarinay <juraj@sarinay.com>
Tue, 2 Sep 2025 11:36:28 +0000 (13:36 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Sep 2025 00:02:12 +0000 (17:02 -0700)
An exchange with a NFC target must complete within NCI_DATA_TIMEOUT.
A delay of 700 ms is not sufficient for cryptographic operations on smart
cards. CardOS 6.0 may need up to 1.3 seconds to perform 256-bit ECDH
or 3072-bit RSA. To prevent brute-force attacks, passports and similar
documents introduce even longer delays into access control protocols
(BAC/PACE).

The timeout should be higher, but not too much. The expiration allows
us to detect that a NFC target has disappeared.

Signed-off-by: Juraj Šarinay <juraj@sarinay.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250902113630.62393-1-juraj@sarinay.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/nfc/nci_core.h

index e180bdf2f82b0184bee44a2684dcb5e1cdcdc93f..664d5058e66e0140d57b16325b76e6ba36ad7e73 100644 (file)
@@ -52,7 +52,7 @@ enum nci_state {
 #define NCI_RF_DISC_SELECT_TIMEOUT             5000
 #define NCI_RF_DEACTIVATE_TIMEOUT              30000
 #define NCI_CMD_TIMEOUT                                5000
-#define NCI_DATA_TIMEOUT                       700
+#define NCI_DATA_TIMEOUT                       3000
 
 struct nci_dev;