]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ov9282: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:30 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:26 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov9282.c

index c882a021cf18852237bf9b9524d3de0c5b48cbcb..a9f6176e9729d500a40004de92c35b9abf89b08c 100644 (file)
@@ -1135,11 +1135,10 @@ static int ov9282_parse_hw_config(struct ov9282 *ov9282)
        }
 
        /* Get sensor input clock */
-       ov9282->inclk = devm_clk_get(ov9282->dev, NULL);
-       if (IS_ERR(ov9282->inclk)) {
-               dev_err(ov9282->dev, "could not get inclk");
-               return PTR_ERR(ov9282->inclk);
-       }
+       ov9282->inclk = devm_v4l2_sensor_clk_get(ov9282->dev, NULL);
+       if (IS_ERR(ov9282->inclk))
+               return dev_err_probe(ov9282->dev, PTR_ERR(ov9282->inclk),
+                                    "could not get inclk\n");
 
        ret = ov9282_configure_regulators(ov9282);
        if (ret)