]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: fix argument of virDomainNetGetActualDirectMode
authorZhiPeng Lu <lu.zhipeng@zte.com.cn>
Tue, 25 Apr 2017 06:16:20 +0000 (14:16 +0800)
committerCole Robinson <crobinso@redhat.com>
Wed, 10 May 2017 22:02:38 +0000 (18:02 -0400)
it should be a comparison of modes between new and old devices. So
the argument of the second virDomainNetGetActualDirectMode should be
newdev.

Signed-off-by: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
(cherry picked from commit c77bc47f43dff2ceb2b95e1aee6fbe1ec9e32fa3)

src/qemu/qemu_hotplug.c

index 5488b1dd4d177074d1fb6b90f3a5978980852279..9642ebd8facf2c1f709c2a252aafb16e36c076df 100644 (file)
@@ -3273,7 +3273,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
 
     if (STRNEQ_NULLABLE(virDomainNetGetActualDirectDev(olddev),
                         virDomainNetGetActualDirectDev(newdev)) ||
-        virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(olddev) ||
+        virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(newdev) ||
         !virNetDevVPortProfileEqual(virDomainNetGetActualVirtPortProfile(olddev),
                                     virDomainNetGetActualVirtPortProfile(newdev)) ||
         !virNetDevVlanEqual(virDomainNetGetActualVlan(olddev),