]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i2c: designware: Use polling by default when there is no irq resource
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Tue, 1 Jul 2025 12:22:48 +0000 (15:22 +0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 10 Jul 2025 14:18:47 +0000 (10:18 -0400)
The irq resource itself can be used as a generic way to
determine when polling is needed.

This not only removes the need for special additional device
properties that would soon be needed when the platform may
or may not have the irq, but it also removes the need to
check the platform in the first place in order to determine
is polling needed or not.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20250701122252.2590230-2-heikki.krogerus@linux.intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/i2c/busses/i2c-designware-platdrv.c

index 879719e91df2a5af9d753c8a3a49871b5b29c90d..3104f52e32be44ab6854f5da42c83f4d5d9d61bd 100644 (file)
@@ -205,25 +205,28 @@ static void i2c_dw_remove_lock_support(struct dw_i2c_dev *dev)
 
 static int dw_i2c_plat_probe(struct platform_device *pdev)
 {
+       u32 flags = (uintptr_t)device_get_match_data(&pdev->dev);
        struct device *device = &pdev->dev;
        struct i2c_adapter *adap;
        struct dw_i2c_dev *dev;
        int irq, ret;
 
-       irq = platform_get_irq(pdev, 0);
-       if (irq < 0)
+       irq = platform_get_irq_optional(pdev, 0);
+       if (irq == -ENXIO)
+               flags |= ACCESS_POLLING;
+       else if (irq < 0)
                return irq;
 
        dev = devm_kzalloc(device, sizeof(*dev), GFP_KERNEL);
        if (!dev)
                return -ENOMEM;
 
-       dev->flags = (uintptr_t)device_get_match_data(device);
        if (device_property_present(device, "wx,i2c-snps-model"))
-               dev->flags = MODEL_WANGXUN_SP | ACCESS_POLLING;
+               flags = MODEL_WANGXUN_SP | ACCESS_POLLING;
 
        dev->dev = device;
        dev->irq = irq;
+       dev->flags = flags;
        platform_set_drvdata(pdev, dev);
 
        ret = dw_i2c_plat_request_regs(dev);