]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test: stop piping post-test journalctl commands to /failed
authorLuca Boccassi <luca.boccassi@gmail.com>
Tue, 4 Nov 2025 12:51:09 +0000 (12:51 +0000)
committerLuca Boccassi <luca.boccassi@gmail.com>
Tue, 4 Nov 2025 15:53:23 +0000 (15:53 +0000)
We can't see what the actual issues are when tests fail at that point, eg:

https://github.com/systemd/systemd/actions/runs/19034752357/job/54356278052

test/units/post.sh

index 9fd50fffaa6a89808cb8cd9f6ee6927d447db86c..55d8ff3ae344f54705c24e9155493977e33c3a75 100755 (executable)
@@ -3,11 +3,11 @@
 set -eux
 set -o pipefail
 
-(! journalctl -q -o short-monotonic --grep "didn't pass validation" | grep -v "test-varlink-idl" >>/failed)
+(! journalctl -q -o short-monotonic --grep "didn't pass validation" | grep -v "test-varlink-idl")
 
 # Here, the redundant '[ ]' in the pattern is required in order not to match the logged command itself.
-(! journalctl -q -o short-monotonic --grep 'Warning: cannot close sd-bus connection[ ].*after fork' >>/failed)
+(! journalctl -q -o short-monotonic --grep 'Warning: cannot close sd-bus connection[ ].*after fork')
 
 # Check if sd-executor doesn't complain about not being able to (de)serialize stuff
-(! journalctl -q -o short-monotonic --grep "[F]ailed to parse serialized line" >>/failed)
-(! journalctl -q -o short-monotonic --grep "[F]ailed to (de)?serialize \w+" >>/failed)
+(! journalctl -q -o short-monotonic --grep "[F]ailed to parse serialized line")
+(! journalctl -q -o short-monotonic --grep "[F]ailed to (de)?serialize \w+")