Extend overflow detection in re_dfa_add_node.

diff --git a/ChangeLog b/ChangeLog
index 7afc90cde6b9ad70f3feda8e551f8bd7d58980da..98c36d5012cd9c537ec48dcb8e2e84709a2bf2d2 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2010-01-22  Jim Meyering  <jim@meyering.net>
 
+       [BZ #11184]
+       * posix/regex_internal.c (re_dfa_add_node): Extend the overflow
+       detection test.  Patch by Paul Eggert.
+
+       [BZ #11183]
        * posix/regex_internal.c (re_string_realloc_buffers):
        Detect and handle internal overflow.  Patch by Paul Eggert
 

diff --git a/posix/regex_internal.c b/posix/regex_internal.c
index 690ed8d8b72fa83e5f582fa7a11152ba31d9813a..67c174a82453dff36767e9fbefaa2b3571d8f565 100644 (file)
--- a/posix/regex_internal.c
+++ b/posix/regex_internal.c
@@ -1411,8 +1411,11 @@ re_dfa_add_node (re_dfa_t *dfa, re_token_t token)
       re_node_set *new_edests, *new_eclosures;
       re_token_t *new_nodes;
 
-      /* Avoid overflows.  */
-      if (BE (new_nodes_alloc < dfa->nodes_alloc, 0))
+      /* Avoid overflows in realloc.  */
+      const size_t max_object_size = MAX (sizeof (re_token_t),
+                                         MAX (sizeof (re_node_set),
+                                              sizeof (int)));
+      if (BE (SIZE_MAX / max_object_size < new_nodes_alloc, 0))
        return -1;
 
       new_nodes = re_realloc (dfa->nodes, re_token_t, new_nodes_alloc);