]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq: simplify boolean parsing with kstrtobool in store function
authorPerry Yuan <perry.yuan@amd.com>
Fri, 21 Jun 2024 16:50:57 +0000 (00:50 +0800)
committerMario Limonciello <mario.limonciello@amd.com>
Mon, 24 Jun 2024 21:16:16 +0000 (16:16 -0500)
Update the cpufreq store function to use kstrtobool for parsing boolean
values. This simplifies the code and improves readability by using a
standard kernel function for boolean string conversion.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Signed-off-by: Perry Yuan <perry.yuan@amd.com>
Link: https://lore.kernel.org/r/d392eba3bad1231776124c321cef8c184ce1482d.1718988436.git.perry.yuan@amd.com
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
drivers/cpufreq/cpufreq.c

index a45aac17c20f0e4cc43d077bbb7f0c688c5d270e..1fdabb660231e5d3b0ef2310a7b16637465fbdb5 100644 (file)
@@ -614,10 +614,9 @@ static ssize_t show_boost(struct kobject *kobj,
 static ssize_t store_boost(struct kobject *kobj, struct kobj_attribute *attr,
                           const char *buf, size_t count)
 {
-       int ret, enable;
+       bool enable;
 
-       ret = sscanf(buf, "%d", &enable);
-       if (ret != 1 || enable < 0 || enable > 1)
+       if (kstrtobool(buf, &enable))
                return -EINVAL;
 
        if (cpufreq_boost_trigger_state(enable)) {
@@ -641,10 +640,10 @@ static ssize_t show_local_boost(struct cpufreq_policy *policy, char *buf)
 static ssize_t store_local_boost(struct cpufreq_policy *policy,
                                 const char *buf, size_t count)
 {
-       int ret, enable;
+       int ret;
+       bool enable;
 
-       ret = kstrtoint(buf, 10, &enable);
-       if (ret || enable < 0 || enable > 1)
+       if (kstrtobool(buf, &enable))
                return -EINVAL;
 
        if (!cpufreq_driver->boost_enabled)