Fix for -Wstringop-overflow false positive

the way the overflow check was written wasn't understood by some
GCC versions and produced false positives for the memset call being
called potentially with object sizes that are larger than half
address-space.

diff --git a/bfd/merge.c b/bfd/merge.c
index c811bc57eae617f71c630d4b9de912315d011662..abb0269227eb7c7c3fd8d271397242a0f8f75311 100644 (file)
--- a/bfd/merge.c
+++ b/bfd/merge.c
@@ -181,9 +181,9 @@ sec_merge_maybe_resize (struct sec_merge_hash *table, unsigned added)
 
       do
        {
-         newnb *= 2;
-         if (!(unsigned int)newnb)
+         if (newnb >> (8 * sizeof(mapofs_type) - 1))
            return false;
+         newnb *= 2;
        }
       while (NEEDS_RESIZE (bfdtab->count + added, newnb));