]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: dsa: b53: prevent SWITCH_CTRL access on BCM5325
authorÁlvaro Fernández Rojas <noltari@gmail.com>
Sat, 14 Jun 2025 07:59:53 +0000 (09:59 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Jun 2025 00:52:12 +0000 (17:52 -0700)
BCM5325 doesn't implement SWITCH_CTRL register so we should avoid reading
or writing it.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Link: https://patch.msgid.link/20250614080000.1884236-8-noltari@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/b53/b53_common.c

index e4e71d193b39b54eb5bb703727a213190b7a44fc..24a9a037212233217d780db10778071cd49f267c 100644 (file)
@@ -361,11 +361,12 @@ static void b53_set_forwarding(struct b53_device *dev, int enable)
 
        b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_MODE, mgmt);
 
-       /* Include IMP port in dumb forwarding mode
-        */
-       b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, &mgmt);
-       mgmt |= B53_MII_DUMB_FWDG_EN;
-       b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, mgmt);
+       if (!is5325(dev)) {
+               /* Include IMP port in dumb forwarding mode */
+               b53_read8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, &mgmt);
+               mgmt |= B53_MII_DUMB_FWDG_EN;
+               b53_write8(dev, B53_CTRL_PAGE, B53_SWITCH_CTRL, mgmt);
+       }
 
        /* Look at B53_UC_FWD_EN and B53_MC_FWD_EN to decide whether
         * frames should be flooded or not.