]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: rockchip: use generic Ethernet PHY reset bindings for Lunzn Fastrhino...
authorChukun Pan <amadeus@jmu.edu.cn>
Wed, 10 Jul 2024 14:30:15 +0000 (22:30 +0800)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 29 Jul 2024 18:50:15 +0000 (20:50 +0200)
Replace the deprecated snps,reset-xxx bindings to the generic Ethernet
PHY reset GPIO bindings. According to the PHY datasheet, the RTL8211F
PHY needs a 10ms assert delay and at least 72ms deassert delay.
Considering the possibility of mixed use of PHY chips, increased the
reset time.

Fixes: b9f8ca655d80 ("arm64: dts: rockchip: Add Lunzn Fastrhino R68S")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Link: https://lore.kernel.org/r/20240710143017.685905-2-amadeus@jmu.edu.cn
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r68s.dts

index ce2a5e1ccefc3f7d54042cefed90af1f652382f3..02d966d218fda2820cb490d89cc164ed967d668a 100644 (file)
                     &gmac0_rx_bus2
                     &gmac0_rgmii_clk
                     &gmac0_rgmii_bus>;
-       snps,reset-gpio = <&gpio1 RK_PB0 GPIO_ACTIVE_LOW>;
-       snps,reset-active-low;
-       /* Reset time is 15ms, 50ms for rtl8211f */
-       snps,reset-delays-us = <0 15000 50000>;
        tx_delay = <0x3c>;
        rx_delay = <0x2f>;
        status = "okay";
                     &gmac1m1_rx_bus2
                     &gmac1m1_rgmii_clk
                     &gmac1m1_rgmii_bus>;
-       snps,reset-gpio = <&gpio1 RK_PB1 GPIO_ACTIVE_LOW>;
-       snps,reset-active-low;
-       /* Reset time is 15ms, 50ms for rtl8211f */
-       snps,reset-delays-us = <0 15000 50000>;
        tx_delay = <0x4f>;
        rx_delay = <0x26>;
        status = "okay";
@@ -76,6 +68,9 @@
                reg = <0x1>;
                pinctrl-0 = <&eth_phy0_reset_pin>;
                pinctrl-names = "default";
+               reset-assert-us = <20000>;
+               reset-deassert-us = <100000>;
+               reset-gpios = <&gpio1 RK_PB0 GPIO_ACTIVE_LOW>;
        };
 };
 
@@ -85,6 +80,9 @@
                reg = <0x1>;
                pinctrl-0 = <&eth_phy1_reset_pin>;
                pinctrl-names = "default";
+               reset-assert-us = <20000>;
+               reset-deassert-us = <100000>;
+               reset-gpios = <&gpio1 RK_PB1 GPIO_ACTIVE_LOW>;
        };
 };