]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
fs: remove useless lockdep assertion
authorChristian Brauner <brauner@kernel.org>
Thu, 19 Dec 2024 13:59:14 +0000 (14:59 +0100)
committerChristian Brauner <brauner@kernel.org>
Thu, 9 Jan 2025 15:58:55 +0000 (16:58 +0100)
mnt_ns_release() can run asynchronously via call_rcu() so hitting that
lockdep assertion means someone else already grabbed the
mnt_ns_tree_lock and causes a false positive. That assertion has likely
always been wrong. call_rcu() just makes it more likely to hit.

Link: https://lore.kernel.org/r/Z2PlT5rcRTIhCpft@ly-workstation
Link: https://lore.kernel.org/r/20241219-darben-quietschen-b6e1d80327bb@brauner
Reported-by: Lai, Yi <yi1.lai@linux.intel.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/namespace.c

index e607762fd9c7038bf400da25f2ab850fd4378dc0..371c860f49de4512b2d2d85ed222b7c62d1e7653 100644 (file)
@@ -160,8 +160,6 @@ static void mnt_ns_tree_add(struct mnt_namespace *ns)
 
 static void mnt_ns_release(struct mnt_namespace *ns)
 {
-       lockdep_assert_not_held(&mnt_ns_tree_lock.lock);
-
        /* keep alive for {list,stat}mount() */
        if (refcount_dec_and_test(&ns->passive)) {
                put_user_ns(ns->user_ns);