]> git.ipfire.org Git - people/ms/linux.git/commitdiff
MIPS: KVM: Deliver guest interrupts after local_irq_disable()
authorJames Hogan <james.hogan@imgtec.com>
Thu, 29 May 2014 09:16:32 +0000 (10:16 +0100)
committerJiri Slaby <jslaby@suse.cz>
Sun, 1 Mar 2015 22:34:17 +0000 (23:34 +0100)
commit 044f0f03eca0110e1835b2ea038a484b93950328 upstream.

When about to run the guest, deliver guest interrupts after disabling
host interrupts. This should prevent an hrtimer interrupt from being
handled after delivering guest interrupts, and therefore not delivering
the guest timer interrupt until after the next guest exit.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@kernel.org>
Cc: kvm@vger.kernel.org
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: Sanjay Lal <sanjayl@kymasys.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
arch/mips/kvm/kvm_mips.c

index 3f3e5b2b2f3834b7351c3b6b972fd6fa1e3a48ec..016f163b42daa3ca985da00a7319a88b2d072aca 100644 (file)
@@ -417,11 +417,11 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu, struct kvm_run *run)
                vcpu->mmio_needed = 0;
        }
 
+       local_irq_disable();
        /* Check if we have any exceptions/interrupts pending */
        kvm_mips_deliver_interrupts(vcpu,
                                    kvm_read_c0_guest_cause(vcpu->arch.cop0));
 
-       local_irq_disable();
        kvm_guest_enter();
 
        r = __kvm_mips_vcpu_run(run, vcpu);