]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
mptcp: fix event attributes type
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Tue, 16 Sep 2025 09:24:33 +0000 (11:24 +0200)
committerStephen Hemminger <stephen@networkplumber.org>
Fri, 26 Sep 2025 17:51:24 +0000 (10:51 -0700)
The 'backup' and 'error' attributes are unsigned.

Even if, for the moment, >2^7 values are not expected, they should be
printed as unsigned (%u) and not as signed (%d).

Fixes: ff619e4f ("mptcp: add support for event monitoring")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
ip/ipmptcp.c

index 118bac4a42a1ea3ce9710510df1353683eb29c89..2415cac8a36089da0e1c42995c06535a08305de7 100644 (file)
@@ -522,9 +522,9 @@ static int mptcp_monitor_msg(struct rtnl_ctrl_data *ctrl,
        if (tb[MPTCP_ATTR_DPORT])
                printf(" dport=%u", rta_getattr_be16(tb[MPTCP_ATTR_DPORT]));
        if (tb[MPTCP_ATTR_BACKUP])
-               printf(" backup=%d", rta_getattr_u8(tb[MPTCP_ATTR_BACKUP]));
+               printf(" backup=%u", rta_getattr_u8(tb[MPTCP_ATTR_BACKUP]));
        if (tb[MPTCP_ATTR_ERROR])
-               printf(" error=%d", rta_getattr_u8(tb[MPTCP_ATTR_ERROR]));
+               printf(" error=%u", rta_getattr_u8(tb[MPTCP_ATTR_ERROR]));
        if (tb[MPTCP_ATTR_FLAGS])
                printf(" flags=%x", rta_getattr_u16(tb[MPTCP_ATTR_FLAGS]));
        if (tb[MPTCP_ATTR_TIMEOUT])