media: tvp7002: fix uninitialized variable warning

tvp7002.c: In function 'tvp7002_g_register':
tvp7002.c:691:11: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
  691 |  reg->val = val;
      |  ~~~~~~~~~^~~~~

Just return without setting 'reg' if tvp7002_read returns an error.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
index de313b1306daae1097371ec64e600a78ee1a5aa0..ada4ec5ef7828e00b955a90e73b124a42015f304 100644 (file)
--- a/drivers/media/i2c/tvp7002.c
+++ b/drivers/media/i2c/tvp7002.c
@@ -688,9 +688,11 @@ static int tvp7002_g_register(struct v4l2_subdev *sd,
        int ret;
 
        ret = tvp7002_read(sd, reg->reg & 0xff, &val);
+       if (ret < 0)
+               return ret;
        reg->val = val;
        reg->size = 1;
-       return ret;
+       return 0;
 }
 
 /*