]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Check that -k argument is provided before trying to use it.
authorAmos Jeffries <squid3@treenet.co.nz>
Fri, 17 Feb 2017 04:53:00 +0000 (17:53 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Fri, 17 Feb 2017 04:53:00 +0000 (17:53 +1300)
 Detected by Coverity Scan. Issue 1364726.

src/main.cc

index 282930cab3ce1ad118438b5113202499c413df93..7e064f717b32d699ab6f94e647a40ce91fa35b2d 100644 (file)
@@ -522,11 +522,11 @@ mainParseOptions(int argc, char *argv[])
             /** \par k
              * Run the administrative action given following the option */
 
-            /** \li When its an unknown option display the usage help. */
-            if ((int) strlen(optarg) < 1)
+            /** \li When it is missing or an unknown option display the usage help. */
+            if (!optarg || strlen(optarg) < 1)
                 usage();
 
-            if (!strncmp(optarg, "reconfigure", strlen(optarg)))
+            else if (!strncmp(optarg, "reconfigure", strlen(optarg)))
                 /** \li On reconfigure send SIGHUP. */
                 opt_send_signal = SIGHUP;
             else if (!strncmp(optarg, "rotate", strlen(optarg)))