]> git.ipfire.org Git - thirdparty/fastapi/fastapi.git/commitdiff
👷 Update docs-previews to handle no docs changes (#11975)
authorSebastián Ramírez <tiangolo@gmail.com>
Thu, 8 Aug 2024 23:28:14 +0000 (18:28 -0500)
committerGitHub <noreply@github.com>
Thu, 8 Aug 2024 23:28:14 +0000 (18:28 -0500)
.github/workflows/deploy-docs.yml
scripts/deploy_docs_status.py

index f28262b2ae9bbf0b2524c5f9401998d226dca1cd..d2953f2841c122fe276b4d560d4620d91a3a733f 100644 (file)
@@ -64,10 +64,10 @@ jobs:
           gitHubToken: ${{ secrets.GITHUB_TOKEN }}
           branch: ${{ ( github.event.workflow_run.head_repository.full_name == github.repository && github.event.workflow_run.head_branch == 'master' && 'main' ) || ( github.event.workflow_run.head_sha ) }}
       - name: Comment Deploy
-        if: steps.deploy.outputs.url != ''
         run: python ./scripts/deploy_docs_status.py
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           DEPLOY_URL: ${{ steps.deploy.outputs.url }}
           COMMIT_SHA: ${{ github.event.workflow_run.head_sha }}
           RUN_ID: ${{ github.run_id }}
+          IS_DONE: "true"
index e00fa2be0efd93cf41b812df40679a5c46b99b84..ef33fe43d940443b030b872dcec2907178fd2e32 100644 (file)
@@ -12,6 +12,7 @@ class Settings(BaseSettings):
     deploy_url: str | None = None
     commit_sha: str
     run_id: int
+    is_done: bool = False
 
 
 def main():
@@ -30,10 +31,19 @@ def main():
     commits = list(use_pr.get_commits())
     current_commit = [c for c in commits if c.sha == settings.commit_sha][0]
     run_url = f"https://github.com/{settings.github_repository}/actions/runs/{settings.run_id}"
+    if settings.is_done and not settings.deploy_url:
+        current_commit.create_status(
+            state="success",
+            description="No Docs Changes",
+            context="deploy-docs",
+            target_url=run_url,
+        )
+        logging.info("No docs changes found")
+        return
     if not settings.deploy_url:
         current_commit.create_status(
             state="pending",
-            description="Deploy Docs",
+            description="Deploying Docs",
             context="deploy-docs",
             target_url=run_url,
         )
@@ -41,7 +51,7 @@ def main():
         return
     current_commit.create_status(
         state="success",
-        description="Deploy Docs",
+        description="Docs Deployed",
         context="deploy-docs",
         target_url=run_url,
     )