]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
memory: ti-aemif: don't needlessly iterate over child nodes
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 9 Aug 2024 14:15:56 +0000 (16:15 +0200)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 12 Aug 2024 10:32:11 +0000 (12:32 +0200)
When populating devices from a specific node, we don't need to call
of_platform_populate() for every child node manually - the routine
will already do it. We can call it directly from the platform device's
OF node. While at it: use the managed variant of of_platform_populate().

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20240809-ti-aemif-v1-3-27b1e5001390@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/memory/ti-aemif.c

index fbe0786f5ac44a46b1e415adbd97873c509b0793..49e7cbe98fdb33bc462839852583c7a570e18a53 100644 (file)
@@ -383,13 +383,9 @@ static int aemif_probe(struct platform_device *pdev)
         * child will be probed after the AEMIF timing parameters are set.
         */
        if (np) {
-               for_each_available_child_of_node(np, child_np) {
-                       ret = of_platform_populate(child_np, NULL, NULL, dev);
-                       if (ret < 0) {
-                               of_node_put(child_np);
-                               return ret;
-                       }
-               }
+               ret = devm_of_platform_populate(dev);
+               if (ret)
+                       return ret;
        }
 
        return 0;